Physics crash

MachineMedic · August 19, 2018, 7:38pm

Using all the BP to build grapnels stacked on top of each other and then deconning the bottom one will crash the 1.3.13 client.

Tremfusion handles it fine.

dGr8LookinSparky · August 21, 2018, 12:59am

That is actually a sound issue in the 1.3 client. If too many sounds are played at the same time (what would happen with a lot of collision sounds from a “grapnel tree drop”, or from a large number of turrets firing at the same time), that would cause a segfault. The relevant sound file has a crappy custom memory allocator that needs a rewrite. It would probably be a good approach to replace that custom memory allocator with at least part of the one Xembie and I made for the game logic:

github.com

GrangerHub/tremulous-game-logic/blob/develop/src/game/bg_alloc.h#L149

      
        
                  if( !( expr ) ){ \
                    BG_MemoryInfo(); \
                    BG_StackPoolMemoryInfo(); \
                    Com_Printf("^3Chunk Size: (^6%lu^3)\n", ( ( size ) ) ); \
                    Com_Printf("^3Memory Chunk Address: (^6%p^3)\n", ( chunkAddress )); \
                    BG_MemFuncCalledFrom( calledFile, calledLine ); \
                    Com_Error( ERR_DROP, "%s:%d: Assertion `%s' failed", \
                               __FILE__, __LINE__, #errString ); \
                  }
            #endif
            
            
/*
            ======================
            allocator_protos
            
            
This macro must be used before using the allocator macro. To limit the access of
            a custom allocator's variables, use this macro in the same file you used the
            allocator macro, and then you can make use of wrappers for external calls to the
            allocator functions.  Or use this macro in a header file for direct access to a
            custom allocator by all files that include said header.
            ======================